-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dockerfile build by sticking to Ubuntu 22.04 #90
Conversation
Signed-off-by: Loganaden Velvindron <[email protected]>
The dockerfile(s) (also) should serve as a canary if something goes haywire downstream, so fixing them to a specific version is not quite ideal. Better would be a functional update wherever necessary to allow current ubuntu versions to keep using OQS. |
@baentsch I can take a look ? |
At what? |
We can take a look at fixing the problem if @SWilson4 hasn't already done so ? |
Found the reference: open-quantum-safe/liboqs#1748 |
That's not good. Is this then a known bug/something that has been reported to the |
Turns out that it's not really a regression, just a behaviour change that broke our CMake config. See open-quantum-safe/liboqs#1748 (comment) and open-quantum-safe/liboqs#1873. |
Tested and it fixes the issue. Successfully built liboqs-python Installing collected packages: nose2, liboqs-python Successfully installed liboqs-python-0.10.0 nose2-0.15.1 Removing intermediate container 7563a817b7d0 ---> 73e2688dcb34 Successfully built 73e2688dcb34 Successfully tagged oqs-python:latest `liboqs version: 0.10.2-dev |
I'll close this PR, then, and will do the same with the related issue when open-quantum-safe/liboqs#1873 lands. Thanks for reporting the bug and testing the fix! |
No description provided.